Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint scout when building #4

Open
rmurphey opened this issue Mar 3, 2015 · 4 comments
Open

Lint scout when building #4

rmurphey opened this issue Mar 3, 2015 · 4 comments

Comments

@rmurphey
Copy link
Contributor

rmurphey commented Mar 3, 2015

No description provided.

@aterranova-bv
Copy link
Contributor

@rmurphey, doing some cleanup - can this be closed? Looks like ESLint is in place.

@sirugh
Copy link
Contributor

sirugh commented Oct 14, 2016

ESLint was added as a pre-commit hook, but I'm not entirely sure that's what she meant by this. It could be that we want to lint the scoutfile when it is generated/built. We pass in flags such as pretty to the scout config when we call it. This tells the scoutfile to add the uglify plugin to the config. Along those same lines we could use eslint-loader and allow users to pass in a lint flag.

@aterranova-bv
Copy link
Contributor

Gotcha. The generated scoutfile is meant to be a part of the consumer's application - should we not let them control how they want their code to look?

@sirugh
Copy link
Contributor

sirugh commented Oct 14, 2016

Yea I think we're on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants