Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mock-fs does not work as expected for Node >20.4 #61

Open
stennie opened this issue Oct 30, 2023 · 1 comment
Open

test: mock-fs does not work as expected for Node >20.4 #61

stennie opened this issue Oct 30, 2023 · 1 comment
Assignees
@stennie

Comments

@stennie
Copy link
Collaborator

stennie commented Oct 30, 2023

mock-fs is currently used for test/generator/local.js. Tests pass in Node 20.4 and earlier, but fail in more recent versions of Node.

Possible related to: tschaub/mock-fs#377

Since this is a very limited use case, I think it could be resolved by either:

  • creating a sample directory to avoid the need for monkey patching core fs behaviour
  • using memfs or an alternative package
@stennie stennie changed the title mock-fs does not work as expected for Node >20.4 test: mock-fs does not work as expected for Node >20.4 Oct 30, 2023
@basti1302
Copy link
Owner

I totally agree. The sample directory sounds like the most straightforward option to me.

@stennie stennie self-assigned this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stennie stennie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stennie @basti1302