-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LWW-Element-Set with Add-Wins semantic for equal timestamp #102
Open
russelldb
wants to merge
20
commits into
develop
Choose a base branch
from
feature/rdb/gh101-lwwset
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Two dialyzer errors:
|
I'll update Roshi's docs to clarify my (perhaps eccentric) use of the term GC, and explicitly mention the possibility of doomstones (hehe). Thanks for writing! |
Typos and clarifications
…cross datatypes for small perf gain
Bring develop up-to-date with develop-2.2
Hex package
Gsets for bet
typo
Fix typo in README.md
Also move to `dict` from `orddict` for better performance in larger sets. Retain `orddict` for EQC for ease of reading.
russelldb
force-pushed
the
feature/rdb/gh101-lwwset
branch
from
January 11, 2018 12:18
083d89b
to
ea3a425
Compare
Re-based on develop. Brought up to date.
Just needs a friendly lil' +1 from someone out there… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An LWW-Element-Set similar to Roshi/The Shapiro Tech Report. When an add and remove on the same element have the same timestamp, the add wins. Why? Makes sense to me that you only remove a element you've seen in the set, and if you remove
a
at time1
then thea
you saw must have been added at some time<1
. Therefore an add ofa
at1
is not the samea
the remove wants to remove.If there is a need for a remove wins version, we could tweak this impl to provide either based on some setup param, I guess.
Despite what the Roshi docs say, there is no GC, and there are in fact tombstones. Once an element is added it will always take up space in the datastructure.
Also, "doomstones" allowed (you can remove
{a, 100000}
whena
is not present, and no add ofa
less than100000
will work.)