Inconsistent capability negotiation. [JIRA: RIAK-1719]

[cmeiklejohn]

Must fix for 1.4 and master.

Sometimes when starting a node, capabilities negotiation doesn't happen correctly. For instance:

([email protected])1> nodes().
['[email protected]']
([email protected])2> riak_core_capability:get({riak_control, member_info_version}).
v0

([email protected])1> nodes().
['[email protected]']
([email protected])2> riak_core_capability:get({riak_control, member_info_version}).
v1

This causes one node to look like an earlier version of Riak Control and be reported as incompatible.

Here are the logs during startup:

12:15:59.133 [info] New capability: {riak_control,member_info_version} = v1

12:15:14.917 [info] New capability: {riak_control,member_info_version} = v0

Finally, two minutes later:

12:17:53.354 [info] Capability changed: {riak_control,member_info_version} / v0 -> v1

[cmeiklejohn]

Tagging @rzezeski, @jtuple and @jonmeredith.

[cmeiklejohn]

The node also shows as incompatible in Riak Control for a short period if it's started and then has to negotiate up to the right capability. To reproduce, start a node while watching the snapshot page of Riak Control.

[cmeiklejohn]

Moving to 2.1.

[DSomogyi]

Comment for Jira.

[Basho-JIRA]

This needs verification, perhaps with a riak_test. I have doubts that if capabilities were really broken in this way, we wouldn't have seen this pop up more in other scenarios.

_[posted via JIRA by Sean Cribbs]_