Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive logging [JIRA: CLIENTS-830] #10

Open
seancribbs opened this issue Jan 12, 2012 · 3 comments
Open

Comprehensive logging [JIRA: CLIENTS-830] #10

seancribbs opened this issue Jan 12, 2012 · 3 comments

Comments

@seancribbs
Copy link
Contributor

Copied from https://github.com/seancribbs/ripple/issues/159 by @seancribbs:

All major operations, especially communications with the Riak host, should be logged with a configurable logger object.

# Should use Rails' logger in the railtie
Riak.logger = Rails.logger

# Allow setting a custom logger
Riak.logger = Logger.new(STDOUT)

It could default to a 'null' logger.

@bkerley bkerley added this to the 3.0 milestone Jul 9, 2014
@lukebakken lukebakken removed this from the 3.0 milestone Feb 28, 2016
@boosty
Copy link
Contributor

boosty commented Apr 27, 2016

A custom logger object was introduced via #248.

@Basho-JIRA Basho-JIRA changed the title Comprehensive logging Comprehensive logging [JIRA: CLIENTS-830] Apr 27, 2016
@boosty
Copy link
Contributor

boosty commented Apr 27, 2016

@lukebakken It was not my intention to close this, since this issue sounds much bigger than just introducing the necessary logger object 😉 But you can decide... I guess it would still make sense to add more logging for the client operations.

@lukebakken
Copy link
Contributor

Got it.

@lukebakken lukebakken reopened this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants