Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GAN to new requirements #58

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Update GAN to new requirements #58

merged 4 commits into from
Nov 15, 2023

Conversation

bolasim
Copy link
Contributor

@bolasim bolasim commented Nov 8, 2023

No description provided.

@squidarth
Copy link
Contributor

could you please add this to the https://github.com/basetenlabs/truss-examples/blob/main/ci.yaml file?

Copy link
Contributor

@squidarth squidarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo adding to ci

@bolasim
Copy link
Contributor Author

bolasim commented Nov 8, 2023

will do. just got to figure out the correct input to test with.

@bolasim
Copy link
Contributor Author

bolasim commented Nov 15, 2023

@squidarth can you take another pass? I made some changes to the CI job to make this testable without making the config unreadable.

@bolasim bolasim merged commit c91c354 into main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants