Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in enforcing SA1200 (using directives inside namespaces) #36

Closed
basdijkstra opened this issue Nov 18, 2022 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@basdijkstra
Copy link
Owner

#34 moved some using directives inside namespaces, and I'd like to apply that consistently throughout the code, also given the arguments here: https://stackoverflow.com/questions/125319/should-using-directives-be-inside-or-outside-the-namespace

Again, this might have some impact on namespaces and imports, similar to #35, thereby breaking the API. Consider this for a 2.0.0 release.

@basdijkstra basdijkstra added the enhancement New feature or request label Nov 18, 2022
@basdijkstra basdijkstra self-assigned this Nov 18, 2022
@basdijkstra
Copy link
Owner Author

Added in d03d434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant