Make HttpCompletionOption configurable

[basdijkstra]

See this discussion for more details: #125

[basdijkstra]

@RothAndrew tagging you so you can follow the progress in here.

[basdijkstra]

@RothAndrew could you upgrade to https://www.nuget.org/packages/RestAssured.Net/4.3.0-beta.1 and test whether setting the HttpCompletionOption works as intended for you? Example:

Given()
    .UseHttpCompletionOption(HttpCompletionOption.ResponseHeadersRead)

The value defaults to HttpCompletionOption.ResponseContentRead, so if that's the value you need, you don't have to specify anything.

In this release, you can only set the HttpCompletionOption value for individual requests, not yet in the RequestSpecification or global config. I'll add that as soon as I know this is what you were looking for.

If you can think of a better name for the UseHttpCompletionOption method I'm open to suggestions ;)

[RothAndrew]

Yep! Will give it a shot now.

[RothAndrew]

It's working great! Thanks! 😁

[RothAndrew]

If you can think of a better name for the UseHttpCompletionOption method I'm open to suggestions ;)

I've always been a fan of using descriptive names over short and cryptic so I love it.

I suppose if you really wanted something different I could potentially see the argument being

// Wait for all the content. Equivalent to using HttpCompletionOption.ResponseContentRead
Given()
  .WaitForContent(true)
  
// Don't wait for content. Equivalent to using HttpCompletionOption.ResponseHeadersRead
Given()
  .WaitForContent(false)

with the default being true to preserve backward compatibility

[basdijkstra]

Thanks so much for the feedback! Happy to hear it works. I’ll add the options to the RequestSpecification and the config options and will release a proper 4.3.0 soon.

[basdijkstra]

@RothAndrew RestAssured.Net 4.3.0 is live: https://www.nuget.org/packages/RestAssured.Net/4.3.0

You can now also specify the HttpCompletionOption in a RequestSpecification and in the global config. Feel free to install and test it.

Please let me know if all still works OK, so I can close the issue. Cheers!

[basdijkstra]

Any more feedback, @RothAndrew? If not I’ll close this issue.

[RothAndrew]

Nope, everything's great. thanks!