Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by "done" first then by "work in progress" #38

Closed
dreamflasher opened this issue Feb 16, 2017 · 13 comments
Closed

Sort by "done" first then by "work in progress" #38

dreamflasher opened this issue Feb 16, 2017 · 13 comments
Assignees

Comments

@dreamflasher
Copy link
Contributor

Is it possible to have the list sorted first by "done" and then by "work in progress", because it would be nice to see the finished ones first.

Or maybe include a date of publication/latest update and sort by that? Then we could attribute conversations to being the first one :)

I would do the work it if you think it's a good idea.

@bascht
Copy link
Owner

bascht commented Feb 16, 2017

Is it possible to have the list sorted first by "done" and then by "work in progress", because it would be nice to see the finished ones first.

That would be nice indeed. I don't think tablesort.js supports sorting by multiple criteria. What works (manually, atm) is: Sorting them first by wip, then by testing and then by done:
screenshot_20170216_201404

You could try to get this to work programmatically. 😄

Or maybe include a date of publication/latest update and sort by that? Then we could attribute conversations to being the first one :)

I think having more metadata would be nice, but it would bloat up our table even more. (See #40).

@dreamflasher
Copy link
Contributor Author

Yeah, manually sorting works right now, but that's not so nice. Actually we don't need three columns, it could be replaced by just one column "status". And I think the status should be in the form "date done" or "date wip" and then we do the default sort on that.

@bascht
Copy link
Owner

bascht commented Feb 16, 2017

Come to think of it: You're completely right! It might be hard to get accurate dates of "Work in Progress" or "Testing", but I'd like to see your idea. Want to give it a go?

@dreamflasher
Copy link
Contributor Author

I'm happy to give it a go :)

@bascht
Copy link
Owner

bascht commented Feb 16, 2017

Let me know if you run into problems setting up the site locally. 😺

@LeSpocky
Copy link
Contributor

FWIW, I like the three column approach.

@dreamflasher
Copy link
Contributor Author

dreamflasher commented Feb 19, 2017

Here's the PR: #41 @bascht :)

@bascht
Copy link
Owner

bascht commented Feb 19, 2017

@LeSpocky I think we can still keep the 3-column look (kind of like a progress bar) while still having a combined state in one field of the data file :)

@dreamflasher
Copy link
Contributor Author

@LeSpocky Could you elaborate what you like about the three column approach? What do you think about my proposal? Maybe something like a progressbar in the field would work?

@ReneVolution
Copy link
Collaborator

I have created PR #42 which would keep the design and fix the issue. What do you guys think?

@bascht
Copy link
Owner

bascht commented May 3, 2017

@ReneVolution @LeSpocky @ReneVolution Can we close this issue?

@LeSpocky
Copy link
Contributor

LeSpocky commented May 3, 2017 via email

@ReneVolution
Copy link
Collaborator

Yep 👍. Looks good for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants