Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crazy interface exmaple does not compile #317

Open
pjustino opened this issue Aug 20, 2017 · 4 comments
Open

Crazy interface exmaple does not compile #317

pjustino opened this issue Aug 20, 2017 · 4 comments

Comments

@pjustino
Copy link
Contributor

Hi Basarat,
I notice that on the interfaces.md file the interface crazy could not be implemented in a class (please check here: microsoft/TypeScript#8917) and I made a fix with some text to explain better the pattern.
I also fixed the constructor to not return any value as it seems not to be possible. Please check here: microsoft/TypeScript#11588

I tried to make a pull request but it seems I got no permissions.

@basarat
Copy link
Owner

basarat commented Aug 21, 2017

I tried to make a pull request but it seems I got no permissions.

You can make a PR. There is no way to block PRs on github so you do have permissions 🌹

@pjustino
Copy link
Contributor Author

I used this command to push the commit:
git push --set-upstream origin pjustino-interface-fix

I got this error:
remote: Permission to basarat/typescript-book.git denied to pjustino.
fatal: unable to access 'https://github.com/basarat/typescript-book.git/': The requested URL returned error: 403

Probably I'm doing something wrong can you please help

@basarat
Copy link
Owner

basarat commented Aug 21, 2017

unable to access 'https://github.com/basarat/typescript-book.git/': T

Your origin should be your fork 🌹

@pjustino
Copy link
Contributor Author

thanks for the help. PR done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants