Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport GPS week rollover (wrong time) highlighting to earlier versions #379

Closed
barbeau opened this issue Feb 25, 2020 · 3 comments
Closed

Comments

@barbeau
Copy link
Owner

barbeau commented Feb 25, 2020

Summary:

As discussed in #369, the GPS week rollover issue impacts mainly older devices. Therefore, it would be nice if we could backport the implementation to highlight these wrong times in PR #376 to earlier GPSTest releases.

It would be nice to support back to Android API level 14 Ice Cream Sandwich 4.0.1.

Steps to reproduce:

Run an older release of GPSTest on a device with API < 18 (our current minSdkVersion - Android 4.3)

Expected behavior:

Highlight wrong times

Observed behavior:

This feature doesn't exist on API < 18 (Android 4.3) releases of GPSTest

Device and Android version:

API < 18 (our current minSdkVersion)

@barbeau
Copy link
Owner Author

barbeau commented Feb 26, 2020

Looks like GPSTest v3.2.11 was the last release for API Level 14-17:
https://github.com/barbeau/gpstest/releases/tag/v3.2.11

@barbeau
Copy link
Owner Author

barbeau commented Feb 26, 2020

Here's a branch with the feature backported:
https://github.com/barbeau/gpstest/tree/v3.2.11-hotfix

@barbeau
Copy link
Owner Author

barbeau commented Feb 27, 2020

@barbeau barbeau closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant