Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

not compatible with recent "@babel/runtime" #78

Open
zetekla opened this issue Mar 21, 2019 · 5 comments
Open

not compatible with recent "@babel/runtime" #78

zetekla opened this issue Mar 21, 2019 · 5 comments

Comments

@zetekla
Copy link

zetekla commented Mar 21, 2019

Can you extend support for "@babel/runtime": "7.4.0" ?

When I have my tsconfig.json like this and "@babel/runtime": "7.0.0-beta.39", my Meteor project works but when I upgrade to 7.1.0 and 7.4.0 it breaks

{
  "compilerOptions": {
    "baseUrl": "./",
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "skipLibCheck": true,
    "allowSyntheticDefaultImports": true,
    "sourceMap": true,
    "allowJs": true,
    "jsx": "react",
    "alwaysStrict": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "rootDir": "src",
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": true,
    "types": ["meteor-typings", "node", "node_modules/@types"],
    "paths": {
      "@imports/*": ["imports/*"]
    }
  },
  "include": [
    "client/**/*",
    "server/**/*",
    "imports/**/*"
  ],
  "exclude": [
    "node_modules",
    ".meteor"
  ],
  "files": [
    "typings/index.d.ts"
  ]
}

Also, I cannot add
"esModuleInterop": true, and "resolveJsonModule": true, my app just no longer works when I added these lines.

@KeithGillette
Copy link

Relatedly, I tried to use the TypeScript 2.9 "resolveJsonModule": true compiler option and got the following error since this package is still based on TypeScript 2.8.3.

=> Errors prevented startup:
   
   While processing files with barbatus:typescript (for target web.browser):
   packages/barbatus:typescript-compiler/typescript-compiler.js:294:13: Format
   of the tsconfig is invalid: Error: Unknown compiler option
   'resolveJsonModule'.
   at TypeScriptCompiler._parseConfig
   (packages/barbatus:typescript-compiler/typescript-compiler.js:294:13)
   at TypeScriptCompiler._processConfig
   (packages/barbatus:typescript-compiler/typescript-compiler.js:262:32)
   at TypeScriptCompiler.getBuildOptions
   (packages/barbatus:typescript-compiler/typescript-compiler.js:82:10)
   at TypeScriptCompiler.processFilesForTarget
   (packages/barbatus:typescript-compiler/typescript-compiler.js:105:26)

@yorrd
Copy link

yorrd commented Mar 26, 2019

Without understanding your issue: try https://atmospherejs.com/adornis/typescript , we forked and are using the newest version of TypeScript, maybe it helps.

@KeithGillette
Copy link

Thanks, @yorrd! In looking elsewhere, I stumbled across your fork and tried it. However, I could not get that package to work without manual work-arounds.

@yorrd
Copy link

yorrd commented Mar 26, 2019

@KeithGillette let's continue conversation over there

@zetekla
Copy link
Author

zetekla commented Apr 13, 2019

@KeithGillette I think for your specific problem, you should use/update your repo with more recent typescript version. Mine is the incompatibility between @babel/runtime and typescript configs (tsconfig.json) to support a Meteor + React app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants