Added partial ARM support for Monitoring integrated service #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
added
kind/enhancement
pregnor
force-pushed
the
3383/chore/update-monitoring-for-partial-arm-support
branch
from
e9d2a6c to
73cbf87
Compare
|
I don't know any critical places where we use the monitoring IS, so I think those breaking changes are probably fine. |
pregnor
force-pushed
the
3383/chore/update-monitoring-for-partial-arm-support
branch
from
73cbf87 to
3004ccc
Compare
pbalogh-sa
approved these changes
Jan 13, 2021
pregnor
force-pushed
the
3383/chore/update-monitoring-for-partial-arm-support
branch
from
3004ccc to
8a56815
Compare
pregnor
force-pushed
the
3383/chore/update-monitoring-for-partial-arm-support
branch
from
8a56815 to
03a79bd
Compare
Note: some of the image version changes involve breaking functionality change in the dependent service. It does not affect Pipeline, but it can potentially affect user experience thus should be mentioned among the release notes.
pregnor
force-pushed
the
3383/chore/update-monitoring-for-partial-arm-support
branch
from
03a79bd to
ac5b6b4
Compare
pregnor
deleted the
3383/chore/update-monitoring-for-partial-arm-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added partial ARM support for Monitoring integrated service
Why?
We would like to support pure ARM and mixed managed clusters in the future, this is a step towards that direction.
Additional context
The reason behind partial support is that we decided to wait for the kube-state-metrics 2.0.0 verion (for ARM support) and official chart.
Major version change release notes:
Prometheus alertmanager:
v0.20.0
v0.21.0
Prometheus node exporter:
v1.0.0
Prometheus operator:
v0.35.0
v0.36.0
v0.37.0
v0.38.0
v0.39.0
v0.40.0
v0.41.0
v0.42.0
v0.43.0
v0.44.0
Prometheus operator chart:
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack#upgrading-an-existing-release-to-a-new-major-version
Grafana:
v7.0
Nothing stood out as Pipeline functionality breaking change (neither by the notes, nor empirically), but there are some possibly user experience breaking changes such as Prometheus default metrics being renamed or removed.
It's up to us to consider whether this is worth it or it's better to wait for a OneEye replacement in Pipeline.
Checklist
OpenAPI and Postman files updated (if needed)User guide and development docs updated (if needed)Related Helm chart(s) updated (if needed)