Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PKE installation process reports #3282

Merged
merged 13 commits into from
Nov 17, 2020
Merged

Handle PKE installation process reports #3282

merged 13 commits into from
Nov 17, 2020

Conversation

orymate
Copy link
Contributor

@orymate orymate commented Nov 4, 2020

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #3174, fixes #3176
License Apache 2.0

What's in this PR?

  • Endpoint for reporting PKE installation steps and results
  • Results are logged and sent to cluster workflows
  • PKE create workflows stop if (one of the master) bootstraps fail.

Checklist

  • Implementation tested (with at least one cloud provider)
  • Code meets the Developer Guide
  • OpenAPI and Postman files updated (if needed)

To Do

  • Another PR can update the hard coded pke version once this, and after that pke is released.

Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I advise waiting for a second opinion.

internal/providers/azure/pke/workflow/create_cluster.go Outdated Show resolved Hide resolved
apis/pipeline/pipeline.yaml Outdated Show resolved Hide resolved
src/api/cluster/pke/pkeservice/service.go Show resolved Hide resolved
internal/app/pipeline/process/process.go Show resolved Hide resolved
pkg/sdk/brn/brn.go Outdated Show resolved Hide resolved
src/api/cluster/pke/pkeservice/service.go Show resolved Hide resolved
Mate Ory added 11 commits November 13, 2020 07:39
The pke-ready signal was only sent if the (master) node succeeded with
the installation of pke. We now accept error signals as well if the node
is known to fail to bootstrap, thus we can interrupt the workflow instad
of the hopeless wait until timeout.

The renaming of the signal makes the different versions of masters and
workers incompatible.
@orymate orymate merged commit 09875d5 into master Nov 17, 2020
@orymate orymate deleted the pke-log branch November 17, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle pke bootstrap errors in cluster creation PKE log retrieval
4 participants