Refactor hard-coded configuration strings into const variables to improve code readability and extensibility #917
+149
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyuenlau
changed the title
|
Friendly ping, when to expect this to be finished. (No pressure just informational.) |
The refactoring itself is pretty much done, the main purpose for the refactoring is to prepare for the KRaft support so things won't look even messier when we add the KRaft. I will just need to do some manual testings to ensure I'm not breaking anything here due to some stupid mistakes |
4 tasks
Kuvesz
approved these changes
Feb 21, 2023
bartam1
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Noticed that the current implementation sets a bunch of hard-coded strings for Kafka and Cruise Control configurations, and I think it's more readable and bug-prune for all the Kafka and Cruise Control configurations to be grouped together in a file so we can use them in the source code
Why?
Concepts that are closely related should be kept vertically close to each other
Test
Test with both internal and external listeners with plaintext, didn't get to test all the security protocols - but triple compared the hard-coded strings with the newly created consts