Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated configs in sample files #870

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Fix deprecated configs in sample files #870

merged 2 commits into from
Oct 5, 2022

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Oct 5, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? yes
License Apache 2.0

What's in this PR?

  • I have removed the deprecated CA cert secret generator
  • I have removed the unnecessary fields in the example CA secret
  • I have removed the unnecessary jksPasswordName (unused in the codebase) field from the example KafkaCluster CRs

Why?

Those are deprecated. Currently, with the help of KafkaUser CR the necessary certificates are generated for the Koperator and listeners thus the user doesn't have to provide those secret data fields.
jksPasswordName is not used in the codebase. It is better to be removed to avoid misunderstanding.

@bartam1 bartam1 requested a review from a team as a code owner October 5, 2022 11:26
@bartam1 bartam1 merged commit b22016f into master Oct 5, 2022
@bartam1 bartam1 deleted the fix_sample_secret branch October 5, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants