Add mechnism to create permissive peerauthenticaion for koperator's default alert manager #856
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault alert manager
pregnor
approved these changes
Aug 26, 2022
pregnor
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add mechnism to create permissive peerauthenticaion for koperator's default alert manager while using the helm chart to install koperator
Why?
The users might need this to allow plaintext traffic to go into the default alert manager port for certain applications that do no support mTLS or not easy to configure to support mTLS (e.g. prometheus)
Additional context
To deploy koperator along with the default peerauthentication CR to set alert manager's port to be PERMISSIVE:
Checklist