Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller gen #838

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Update controller gen #838

merged 2 commits into from
Jul 20, 2022

Conversation

stoader
Copy link
Member

@stoader stoader commented Jul 20, 2022

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

  • Upgrade controller-gen version to v0.9.2
  • Update K8s version used in test env

Why?

Latest version of controller-gen generates CRDs with empty status field (kubernetes-sigs/controller-tools#630), also built with k8s version 1.24

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@stoader stoader requested a review from a team as a code owner July 20, 2022 04:32
@stoader stoader merged commit e5722ba into master Jul 20, 2022
@stoader stoader deleted the update-controller-gen branch July 20, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuvesz Kuvesz Kuvesz approved these changes

@pregnor pregnor pregnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stoader @pregnor @Kuvesz