-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envoy config generated by the operator is invalid in envoy 1.22 #823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the user can override the image for Envoy via envoyConfig.image
the config generation should take into account the version and generate config specific to the version.
The other option is we mandate the use of Envoy 1.22.2 and above from now on.
Good points @stoader - in fact the new generated version of envoy.yaml should be backward compatible with envoy < 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good if it is indeed backward compatible.
Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ```
@stoader @Kuvesz I updated the PR to include only the minimal changes to make the generated config compatible with newer versions of envoy (e.g. 1.22.x) I'll follow-up with a separate PR to make envoy 1.22 as min required if you agree: |
Thanks! 👍 |
What's in this PR?
Envoy config generated by the operator was not compatible with newer version of the envoy. More specifically in v1.22 the config is invalid:
This PR addresses this by:
Why?
Being able to upgrade to newer version of envoy when envoy ingress is used to front Kafka clusters.
Additional context
Checklist