Replace super.users with const var

pkg/resources/envoy/envoy.go

@@ -61,22 +61,22 @@ func (r *Reconciler) Reconcile(log logr.Logger) error {
 				if err != nil {
 					return err
 				}
-				var externalListernerResources []resources.ResourceWithLogAndExternalListenerSpecificInfos
-				externalListernerResources = append(externalListernerResources,
+				var externalListenerResources []resources.ResourceWithLogAndExternalListenerSpecificInfos
+				externalListenerResources = append(externalListenerResources,
 					r.service,
 					r.configMap,
 					r.deployment,
 				)
 
 				if r.KafkaCluster.Spec.EnvoyConfig.GetDistruptionBudget().DisruptionBudget.Create {
-					externalListernerResources = append(externalListernerResources, r.podDisruptionBudget)
+					externalListenerResources = append(externalListenerResources, r.podDisruptionBudget)
 				}
 				for name, ingressConfig := range ingressConfigs {
 					if !util.IsIngressConfigInUse(name, defaultControllerName, r.KafkaCluster, log) {
 						continue
 					}
 
-					for _, res := range externalListernerResources {
+					for _, res := range externalListenerResources {
 						o := res(log, eListener, ingressConfig, name, defaultControllerName)
 						err := k8sutil.Reconcile(log, r.Client, o, r.KafkaCluster)
 						if err != nil {

pkg/resources/kafka/configmap.go

@@ -347,11 +347,11 @@ func generateListenerSSLConfig(config *properties.Properties, name string, sslCl
 // mergeSuperUsersPropertyValue merges the target and source super.users property value, and returns it as string.
 // It returns empty string when there were no updates or any of the super.users property value was empty.
 func mergeSuperUsersPropertyValue(source *properties.Properties, target *properties.Properties) string {
-	sourceVal, foundSource := source.Get("super.users")
+	sourceVal, foundSource := source.Get(kafkautils.KafkaConfigSuperUsers)
 	if !foundSource || sourceVal.IsEmpty() {
 		return ""
 	}
-	targetVal, foundTarget := target.Get("super.users")
+	targetVal, foundTarget := target.Get(kafkautils.KafkaConfigSuperUsers)
 	if !foundTarget || targetVal.IsEmpty() {
 		return ""
 	}
@@ -397,7 +397,7 @@ func (r Reconciler) generateBrokerConfig(id int32, brokerConfig *v1beta1.BrokerC
 		if suMerged := mergeSuperUsersPropertyValue(finalBrokerConfig, opGenConf); suMerged != "" {
 			// Setting string value for a property is not going to run into error, also we don't return error in this function
 			//nolint:errcheck
-			opGenConf.Set("super.users", suMerged)
+			opGenConf.Set(kafkautils.KafkaConfigSuperUsers, suMerged)
 		}
 		finalBrokerConfig.Merge(opGenConf)
 	}