From a58caedf3de9ea5270208a054e7120ff31dbe4b9 Mon Sep 17 00:00:00 2001 From: Szabolcs Berecz Date: Mon, 29 Jun 2020 15:04:00 +0200 Subject: [PATCH 1/2] Run shellcheck on ci --- .circleci/config.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6030de088..ed819219d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -95,12 +95,8 @@ jobs: make generate - run: - name: Run linter - command: make lint - - - run: - name: Run unit tests - command: make test + name: Run unit tests, linter, etc. + command: make check when: always - save_cache: From 27d2017a501149e3ec55c2853ceac96b6e0ed0ae Mon Sep 17 00:00:00 2001 From: Szabolcs Berecz Date: Mon, 29 Jun 2020 15:05:01 +0200 Subject: [PATCH 2/2] Do not run `make check` when previous steps fail It's no use to run tests or linters when code generation fails. --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ed819219d..504f5135a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -97,7 +97,6 @@ jobs: - run: name: Run unit tests, linter, etc. command: make check - when: always - save_cache: name: Save build dependencies