Gutenberg: contribute story for menu-group

[bangank36]

Summary

Use this issue to track the process of making story for Gutenberg menu-group item

• Github: menu-group dir
• Discussion on type
  https://togithub.com/WordPress/gutenberg/pull/47180#discussion_r1087888664

There is story of menu-group''s child menu-item-choices

• menu-items-choice Storybook
• menu-items-choice Github

Currently all components stories are using addon-knobs, I think we should start using addon-controls for this component

🚧 Proposed PR:

MenuGroup: Add Storybook stories

• 28-July-2023: waiting for review

Get started with Gutenberg

• https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/
• First i have to use nvm for downgrade node to 14 with npm v6

Reference

Initial discussion on the contribution
Storybook docs

[bangank36]

27 July 2023

• Options of menu-group https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/menu-group/types.ts

1. label
2. dividers

• Current state of story
  • To add description of the props we need type file with detail comment
  • For generated code to copy we need to return the Template
  • For ColorPalette, the CSS variables showing Template component, does not make sense?
  • First item with example code can be found on main file of menu group
  • meta: ComponentMeta< typeof ButtonGroup > will expect type of component to parse the prop property

[bangank36]

28 July 2023

• Storybook docs only works if import from the default export of component that is relative to the stories, import directly from wordpress/components did not work
  import MenuGroup from '..'; > import { MenuGroup } from '@wordpress/components';

Can not commit

✖ node ./bin/packages/lint-staged-typecheck.js found some errors. Please fix them and try committing again.

error TS5055: Cannot write file '/Users/nganle/Documents/Automattic/gutenberg/packages/components/build-types/alignment-matrix-control/icon.d.ts' because it would overwrite input file.

Following this https://togithub.com/WordPress/gutenberg/pull/18942 to fix, some thing wrong with write permission?
Use internal import and re-run npm run clean:package-types helps

[bangank36]

Closed as PR merged