Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple vuex-toolkit from sagas and extend Store in a backward-compatible way #4

Open
banderror opened this issue May 27, 2020 · 0 comments
Labels
breaking change Breaking change in the library API and/or behaviour type: visible enhancement New feature, change in the library API or expected behaviour

Comments

@banderror
Copy link
Owner

banderror commented May 27, 2020

Decouple vuex-toolkit from sagas. Implement vuex saga plugin as a vuex-toolkit-saga "extension" - a separate package.

Create an extended Store interface. Something like

interface VuexToolkitStore<S> extends Store<S> {
  run: RunSaga;
  send: SendMessage;
}

Create 2 versions of the send() method (maybe send and put, or send and resolve - naming to be decided). One should be synchronous and return void, the other one should be async and return a Promise. Both should work with all kinds of messages that vuex-toolkit supports.

@banderror banderror changed the title Decouple vuex-toolkit from sagas Decouple vuex-toolkit from sagas and extend Store in a backward-compatible way May 27, 2020
@banderror banderror added breaking change Breaking change in the library API and/or behaviour type: visible enhancement New feature, change in the library API or expected behaviour labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change in the library API and/or behaviour type: visible enhancement New feature, change in the library API or expected behaviour
Projects
None yet
Development

No branches or pull requests

1 participant