Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to log indicating failure on rejection #15

Open
micahjsmith opened this issue Aug 18, 2020 · 2 comments
Open

Add link to log indicating failure on rejection #15

micahjsmith opened this issue Aug 18, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@micahjsmith
Copy link
Contributor

If check fails (such as Feature API Check), then insert a link in the closing message to the failing check.

E.g.

The following checks failed: [check1](check1), [check2](check2).
@micahjsmith micahjsmith added the enhancement New feature or request label Aug 18, 2020
@micahjsmith
Copy link
Contributor Author

  1. Store job ids of failed jobs (See https://developer.travis-ci.com/resource/job)
  2. Get repo owner and slug
  3. Construct url to user-facing log
  4. Add a link in index.js shouldCloseRejectedFeature line 182 (reason = '<n/a>')

@micahjsmith
Copy link
Contributor Author

See also https://probot.github.io/apps/ci-reporter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micahjsmith