You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Public client classes
http:Client
http:LoadBalanceClient
http:FailoverClient
Internal Client classes
HttpClient - which is native client connector
HttpSecureClient
RetryClient
RedirectClient
HttpCachingClient
CircuitBreakerClient
CookieClient
All these internal clients are structurally equal. So whatever we do, should be done to all of them. When trying to make the private, it blocks at CircuitBreakerClient level. because CircuitBreakerClient some additional APIs also. Eg: forceClose(), forceOpen().
So as a solution, we can make CircuitBreakerClient a public client and hide all other clients.
Public client classes
http:Client
http:LoadBalanceClient
http:FailoverClient
http:CircuitBreakerClient
This API change is not backward compatible and can affect the users
Public client classes
http:Client
http:LoadBalanceClient
http:FailoverClient
Internal Client classes
HttpClient - which is native client connector
HttpSecureClient
RetryClient
RedirectClient
HttpCachingClient
CircuitBreakerClient
CookieClient
All these internal clients are structurally equal. So whatever we do, should be done to all of them. When trying to make the private, it blocks at CircuitBreakerClient level. because CircuitBreakerClient some additional APIs also. Eg: forceClose(), forceOpen().
So as a solution, we can make CircuitBreakerClient a public client and hide all other clients.
Public client classes
http:Client
http:LoadBalanceClient
http:FailoverClient
http:CircuitBreakerClient
This API change is not backward compatible and can affect the users
When checking the implementation, it was found that http:HttpClient was visible for circuit breaker to execute 3 methods.
Description:
The 'http: HttpClient' object details (which should be private) can still be seen in the ballerina api-docs [1].
[1] https://ballerina.io/learn/api-docs/ballerina/http/clients/HttpClient.html
The text was updated successfully, but these errors were encountered: