Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Adding All Possible Federated Directives to SDL String in GraphQL Subgraph #4681

Closed
MohamedSabthar opened this issue Jul 26, 2023 · 4 comments · Fixed by ballerina-platform/module-ballerina-graphql#1555
Assignees
Labels
module/graphql Issues related to Ballerina GraphQL module Reason/Other None of the other reasons. Team/PCM Protocol connector packages related issues Type/Bug

Comments

@MohamedSabthar
Copy link
Member

Description:
The Current Implementation of Subgraph Includes All the Federated Directives Listed Here: https://www.apollographql.com/docs/federation/subgraph-spec.

Since the current implementation only supports the @key directive, we should only add this directive to the auto-generated SDL string.

Describe your problem(s)

Describe your solution(s)

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@ThisaruGuruge
Copy link
Member

Closing as this has to be confirmed from the Apollo federation spec. @DimuthuMadushan let's link the issue here.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Ballerina Team Main Board Jul 27, 2023
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@ThisaruGuruge ThisaruGuruge added the Reason/Other None of the other reasons. label Jul 27, 2023
@DimuthuMadushan
Copy link

@DimuthuMadushan
Copy link

DimuthuMadushan commented Jul 28, 2023

Re-open the issue due to this apollographql/apollo-federation-subgraph-compatibility#475 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/graphql Issues related to Ballerina GraphQL module Reason/Other None of the other reasons. Team/PCM Protocol connector packages related issues Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants