Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete type info given in compiler errors issued from GraphQL compiler plugin #3865

Closed
pubudu91 opened this issue Dec 20, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#1149
Assignees
Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Type/Bug Type/Improvement
Milestone

Comments

@pubudu91
Copy link

For example, consider the following:

resource function get deployments(http:Headers headers) {}

For the above sort of resource method, it gives the following compiler error:

Invalid GraphQL input parameter type `Headers`

Main issue with the above is the type info in this is incomplete. It should be given as http:Headers. i.e., fully qualified name.

Two minor issues:

  • Use of back ticks instead of single quotes to quote the type name.
  • Use of upper case letter at the start.
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@MohamedSabthar MohamedSabthar added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Jan 3, 2023
@ThisaruGuruge ThisaruGuruge added this to the 2201.4.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Type/Bug Type/Improvement
Projects
Archived in project
3 participants