Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL Subscriptions does not Close the Stream After it is Completed #3661

Closed
ThisaruGuruge opened this issue Nov 16, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#1067
Closed

GraphQL Subscriptions does not Close the Stream After it is Completed #3661

ThisaruGuruge opened this issue Nov 16, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#1067
Assignees
@ThisaruGuruge
Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Milestone
2201.3.0

Comments

@ThisaruGuruge
Copy link
Member

Description:
When a GraphQL subscription is completed (by sending the completion type in the stream), the stream should be closed before closing the connection/closing the subscription operation.
@ThisaruGuruge ThisaruGuruge added Points/1 Type/Bug module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues labels Nov 16, 2022
@ThisaruGuruge ThisaruGuruge self-assigned this Nov 16, 2022
@ThisaruGuruge ThisaruGuruge mentioned this issue Nov 16, 2022
Merged
5 tasks
Repository owner moved this from In Progress to Done in Ballerina Team Main Board Nov 16, 2022
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@ThisaruGuruge ThisaruGuruge mentioned this issue Nov 16, 2022
Merged
5 tasks
@ThisaruGuruge ThisaruGuruge added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Nov 16, 2022
@ThisaruGuruge ThisaruGuruge added this to the 2201.3.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThisaruGuruge ThisaruGuruge

Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Projects
None yet
Milestone
2201.3.0
Development

Successfully merging a pull request may close this issue.

Close the Stream when a Subscription Operation is Completed ThisaruGuruge/module-ballerina-graphql
1 participant
@ThisaruGuruge