Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Deprecation in GraphQL #2898

Closed
ThisaruGuruge opened this issue May 11, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#772
Closed

Support Deprecation in GraphQL #2898

ThisaruGuruge opened this issue May 11, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#772
Assignees
Labels
module/graphql Issues related to Ballerina GraphQL module Points/0.5 Points/4 Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@ThisaruGuruge
Copy link
Member

ThisaruGuruge commented May 11, 2022

Description:
In a GraphQL schema, a field or an enum value can be deprecated. If deprecated, the users can include the deprecation reason for the particular field or the enum value.

In Ballerina, a field or an enum value in a GraphQL service can be marked deprecated using the existing Ballerina annotations. The Ballerina documentation even supports the deprecation reason through the Ballerina doc comments.

But when filtering the values using the includeDeprecated = false argument, the values aren't filtered correctly.

@ThisaruGuruge ThisaruGuruge added Type/Improvement module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues labels May 11, 2022
@ThisaruGuruge ThisaruGuruge self-assigned this May 17, 2022
@shafreenAnfar shafreenAnfar moved this to StandardLibrary-PCM in Swan Lake Update 2 May 20, 2022
@ThisaruGuruge
Copy link
Member Author

This cannot be supported for INPUT_OBJECT types due to ballerina-platform/ballerina-spec#823. The @deprecated directive support for the input object fields will be tracked via #2998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/graphql Issues related to Ballerina GraphQL module Points/0.5 Points/4 Team/PCM Protocol connector packages related issues Type/Improvement
Projects
No open projects
Status: StandardLibrary-PCM
Development

Successfully merging a pull request may close this issue.

1 participant