Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure CORS #1475

Closed
shafreenAnfar opened this issue Jun 15, 2021 · 2 comments · Fixed by ballerina-platform/module-ballerina-graphql#537
Closed

Ability to configure CORS #1475

shafreenAnfar opened this issue Jun 15, 2021 · 2 comments · Fixed by ballerina-platform/module-ballerina-graphql#537
Assignees
@DimuthuMadushan
Labels
module/graphql Issues related to Ballerina GraphQL module Points/7 Priority/High Team/PCM Protocol connector packages related issues Type/Improvement

Comments

@shafreenAnfar
Copy link
Contributor

I get this when trying to connect with https://www.graphqlbin.com/v2/new

shafreen:snowtooth shafreen$ bal run

Compiling source
	graphql/snowtooth:0.1.0

Running executable

[ballerina/http] started HTTP/WS listener 0.0.0.0:9000
time = 2021-06-15 12:10:59,089 level = INFO  module = "" Failed to process CORS : access control request method not allowed

We need to be able to configure CORS as in https://ballerina.io/learn/by-example/http-cors
@shafreenAnfar shafreenAnfar added Priority/Low Type/Improvement module/graphql Issues related to Ballerina GraphQL module labels Jun 15, 2021
@ldclakmal ldclakmal added the Team/PCM Protocol connector packages related issues label Jun 25, 2021
@ThisaruGuruge
Copy link
Member

There's a requirement from Choreo for this. Therefore increase the priority

@DimuthuMadushan
Copy link

This is temporarily blocked until merging the lang PR Add closure support for object constructor.

@DimuthuMadushan DimuthuMadushan mentioned this issue Dec 21, 2021
Merged
3 tasks
@ThisaruGuruge ThisaruGuruge reopened this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimuthuMadushan DimuthuMadushan

Labels
module/graphql Issues related to Ballerina GraphQL module Points/7 Priority/High Team/PCM Protocol connector packages related issues Type/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CORS configure support for GraphQL services DimuthuMadushan/module-ballerina-graphql
4 participants
@shafreenAnfar @ldclakmal @DimuthuMadushan @ThisaruGuruge