Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Test failure in OpenAPI-tools after new changes to Balletina.toml diagnostics #5987

Closed
ShammiL opened this issue Jan 29, 2024 · 0 comments

Comments

@ShammiL
Copy link

ShammiL commented Jan 29, 2024

Description:

testEmptyOpenApiContractForBalProject test in OpenAPI-tools is failing after a change done to Ballerina.toml diagnostics.

Current test implementation only checks for a single diagnostic,
WARNING [main.bal:(16:1,24:2)] given OpenAPI contract file path is an empty string. but after the new changes there's a new diagnostic added.

WARNING [Ballerina.toml:(1:1,29:1)] missing table '[package]' in 'Ballerina.toml'. Defaulting to:
[package]
org = "shammi"
name = "sample_tool_runner"
version = "0.1.0"

This is ignored during the test assertions.

There are two ways to fix this:

  1. Include the package table in the sample(sample 8) Ballerina project used for the test so the new warning diagnostic will not be reported.
  2. Change the test to correctly assert both diagnostics.

Steps to reproduce:

Use the timestamp version containing the new changes and run bal build for sample 8.

Affected Versions:

OS, DB, other environment details and versions:

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@lnash94 lnash94 changed the title [Bug]: Test failure in OpenAPI-tools after new changes to Balletina.toml diagnostics [Task]: Test failure in OpenAPI-tools after new changes to Balletina.toml diagnostics Jan 29, 2024
@lnash94 lnash94 moved this to Todo in OpenAPI Tool Roadmap Jan 29, 2024
@lnash94 lnash94 moved this to In Progress in Ballerina Team Main Board Feb 13, 2024
@lnash94 lnash94 moved this from In Progress to PR Sent in Ballerina Team Main Board Feb 13, 2024
@lnash94 lnash94 closed this as completed Feb 14, 2024
@github-project-automation github-project-automation bot moved this from PR Sent to Done in Ballerina Team Main Board Feb 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in OpenAPI Tool Roadmap Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants