We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module-websubhub
Description:
Some of the Java classes in websubhub module, namely:
websubhub
NativeHttpToWebsubhubAdaptor
AnalyserUtils
appear to be utility classes (i.e. all of the members and methods are static). Generally speaking it is a good practice to:
static
private
ModuleUtils
final
There are benefits of doing this:
Suggested Labels:
module/websubhub,hacktoberfest
Suggested Assignees:
@vil02
Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:
#4894, #4901, #4902.
The text was updated successfully, but these errors were encountered:
module-graphql
module-email
module-mqtt
module-sql
module-http
module-udp
module-websub
module-constraint
module-grpc
module-mime
module-tcp
module-os
module-task
module-ftp
module-soap
Successfully merging a pull request may close this issue.
Description:
Some of the Java classes in
websubhub
module, namely:NativeHttpToWebsubhubAdaptor
,AnalyserUtils
,appear to be utility classes (i.e. all of the members and methods are
static
). Generally speaking it is a good practice to:private
(like inModuleUtils
) - because it does not make sense to have objects of such classes,final
- because it does not make sense to derive any class from them.There are benefits of doing this:
Suggested Labels:
module/websubhub,hacktoberfest
Suggested Assignees:
@vil02
Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:
#4894, #4901, #4902.
The text was updated successfully, but these errors were encountered: