Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data binding mime type match #3542

Closed
chamil321 opened this issue Oct 21, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-http#1279
Closed

Improve data binding mime type match #3542

chamil321 opened this issue Oct 21, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-http#1279
Assignees
Labels
module/http Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Milestone

Comments

@chamil321
Copy link
Contributor

chamil321 commented Oct 21, 2022

Description:
Currently text/javascript matched to string builder due to primary text component. But it contains a json structure and lead to binding error. The regex match should be improved to allow 1:1 matching standard mime types such as

  • text/plain
  • application/json
  • application/xml
  • application/x-www-form-urlencoded
  • application/octet-stream

Also allow some of the close variation as well such as - application/Id+json.
Other than that, consider rest of the mime types as unknown and treat as json compatibles

@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/http Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants