Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Write a separate Node Visitor for Type-checking the Group by and Collect clause #38774

Closed
gimantha opened this issue Nov 22, 2022 · 1 comment
Closed

[Task]: Write a separate Node Visitor for Type-checking the Group by and Collect clause #38774

gimantha opened this issue Nov 22, 2022 · 1 comment
Assignees
@KavinduZoysa
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Task userCategory/Compilation
Milestone
2201.6.0

Comments

@gimantha
Copy link
Contributor

Description

The way the aggregated variables behave is context-specific. Aggregated variables are created in a frame only when we have a group by clause or a collect clause. Their usage is valid only in aggregated functions like sum. (which accepts rest args) and list constructors ( where we can use the spread operators on arrays). In future, there can be cases where we have to add, multiply, subtract.. etc between aggregated variables. and Having all these semantic changes in our default semantic analyzer can complicate the implementation. So the suggestion is to have a different type-checker for aggregated variables.

Describe your task(s)

No response

Related area

-> Compilation

Related issue(s) (optional)

ballerina-platform/ballerina-spec#441

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response
@gimantha gimantha self-assigned this Nov 22, 2022
@gimantha gimantha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Nov 22, 2022
@gimantha gimantha moved this to In Progress in Ballerina Team Main Board Nov 22, 2022
@gimantha gimantha added the Points/5 Equivalent to five day effort label Nov 22, 2022
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Nov 22, 2022
@anupama-pathirage anupama-pathirage removed the needTriage The issue has to be inspected and labeled manually label Nov 22, 2022
@gimantha gimantha moved this from In Progress to On Hold in Ballerina Team Main Board Jan 17, 2023
@gimantha gimantha moved this from On Hold to In Progress in Ballerina Team Main Board Jan 30, 2023
@gimantha gimantha moved this from In Progress to On Hold in Ballerina Team Main Board Feb 22, 2023
@gimantha gimantha assigned KavinduZoysa and unassigned gimantha Mar 30, 2023
@gimantha gimantha moved this from On Hold to Planned for Sprint in Ballerina Team Main Board Mar 30, 2023
@gimantha gimantha removed the Points/5 Equivalent to five day effort label Mar 30, 2023
@gimantha gimantha added this to the 2201.6.0 milestone Mar 30, 2023
@KavinduZoysa
Copy link
Contributor

KavinduZoysa commented May 25, 2023 •
edited
Loading

This will be handled in #40447

@github-project-automation github-project-automation bot moved this from Planned for Sprint to Done in Ballerina Team Main Board May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KavinduZoysa KavinduZoysa

Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Task userCategory/Compilation
Projects
Ballerina Team Main Board
Archived in project
Milestone
2201.6.0
Development

No branches or pull requests
4 participants
@gimantha @anupama-pathirage @ballerina-bot @KavinduZoysa