Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature]: Provide completion and related LS support for new regex support #38095

Closed
IMS94 opened this issue Oct 6, 2022 · 4 comments · Fixed by #38496
Closed

[New Feature]: Provide completion and related LS support for new regex support #38095

IMS94 opened this issue Oct 6, 2022 · 4 comments · Fixed by #38496
Assignees
@TharushiJay
Labels
Area/Completion Issues related to Language Server Auto Completions Lang/Regexp Issues related to Ballerina regular expressions Points/5 Equivalent to five day effort Reason/Other None of the other reasons. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature userCategory/Editor
Milestone
2201.4.0

Comments

@IMS94
Copy link
Contributor

IMS94 commented Oct 6, 2022 •
edited
Loading

Description

Consider the following new addition to support regex:

 string:RegExp regex = re `[0-9a-${endChar}]`;

LS should support completion support etc here.

Related area

-> Editor
@IMS94 IMS94 added Type/NewFeature Team/LanguageServer Language Server Implementation related issues. #Compiler Area/Completion Issues related to Language Server Auto Completions labels Oct 6, 2022
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Editor labels Oct 6, 2022
@IMS94 IMS94 removed the needTriage The issue has to be inspected and labeled manually label Oct 6, 2022
@IMS94 IMS94 added the Points/1 Equivalent to one day effort label Oct 6, 2022
@IMS94 IMS94 added this to the 2201.4.0 milestone Oct 6, 2022
@dulajdilshan
Copy link
Contributor

dulajdilshan commented Oct 18, 2022 •
edited
Loading

Related Github discussion: #36805

@dulajdilshan
Copy link
Contributor

Compiler FE changes: #37916

@LakshanWeerasinghe LakshanWeerasinghe added the Points/5 Equivalent to five day effort label Oct 20, 2022
@IMS94 IMS94 removed the Points/1 Equivalent to one day effort label Oct 20, 2022
@dulajdilshan
Copy link
Contributor

LS requirements can be found in the comments in RegExp KT

@mohanvive mohanvive moved this to Language Server in Swan Lake Update 4 Oct 25, 2022
@TharushiJay TharushiJay mentioned this issue Nov 1, 2022
Merged
13 tasks
@TharushiJay TharushiJay mentioned this issue Nov 4, 2022
Closed
@pcnfernando
Copy link
Member

pcnfernando commented Nov 10, 2022 •
edited
Loading

Wondering if it is possible to support ReBaseQuantifier, ReSyntaxChar, and whatever we have a set of options. It shouldn't anyway be a completion since we can't be sure what the next node be. But maybe just suggestions when we do 'Ctrl + Space'?

@pcnfernando pcnfernando added the Lang/Regexp Issues related to Ballerina regular expressions label Nov 23, 2022
@IMS94 IMS94 added the Reason/Other None of the other reasons. label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TharushiJay TharushiJay

Labels
Area/Completion Issues related to Language Server Auto Completions Lang/Regexp Issues related to Ballerina regular expressions Points/5 Equivalent to five day effort Reason/Other None of the other reasons. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/NewFeature userCategory/Editor
Projects
Ballerina Team Main Board
Archived in project
Swan Lake Update 4
Status: Language Server
Milestone
2201.4.0
Development

Successfully merging a pull request may close this issue.

Add completion support for regular expressions TharushiJay/ballerina-lang
6 participants
@IMS94 @pcnfernando @dulajdilshan @ballerina-bot @TharushiJay @LakshanWeerasinghe