Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little inconsistency in error messages, while validating JWTs #11142

Closed
prabath opened this issue Oct 31, 2018 · 1 comment
Closed

Little inconsistency in error messages, while validating JWTs #11142

prabath opened this issue Oct 31, 2018 · 1 comment
Assignees
Labels
Team/StandardLibs All Ballerina standard libraries Type/Improvement

Comments

@prabath
Copy link

prabath commented Oct 31, 2018

If the we directly hit a service with an expired JWT (before being added to the cache) - following is the error on the logs:

2018-10-31 06:08:46,174 DEBUG [ballerina/http] - Trying to authenticate with the auth provider: jwt-1
2018-10-31 06:08:46,348 ERROR [ballerina/http] - Error while validating JWT token : {message:"JWT token is expired", cause:null}

If the JWT is in the cache - and try the same (JWT) after it expires - I don't see any error logs.

2018-10-31 06:08:19,760 DEBUG [ballerina/http] - Trying to authenticate with the auth provider: jwt-1

@ldclakmal ldclakmal self-assigned this Aug 7, 2019
@ldclakmal
Copy link
Member

This is now fixed with the refactoring of the authn/authz framework [1] [2] for Ballerina 1.0. The inconsistency in error messages is also fixed along with that.

[1] #15056
[2] #15696

@ldclakmal ldclakmal added this to the Ballerina 1.0.0-beta milestone Aug 13, 2019
@keizer619 keizer619 modified the milestones: Ballerina 1.0.0-beta, Ballerina 1.0.0 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/StandardLibs All Ballerina standard libraries Type/Improvement
Projects
None yet
Development

No branches or pull requests

4 participants