Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balena-image: include peak driver #165

Merged
merged 1 commit into from
Nov 30, 2022
Merged

balena-image: include peak driver #165

merged 1 commit into from
Nov 30, 2022

Conversation

mtoman
Copy link
Contributor

@mtoman mtoman commented Nov 29, 2022

This is a 3rd party CAN driver, we want to include it in the generic device types.

This is a 3rd party CAN driver, we want to include it in the generic
device types.

Change-type: patch
Changelog-entry: Include peak CAN driver
Signed-off-by: Michal Toman <[email protected]>
@mtoman mtoman requested review from alexgg and jakogut November 29, 2022 12:00
Copy link
Contributor

@jakogut jakogut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtoman Do we need this in balena-intel as well, or is it already included?

@alexgg
Copy link
Collaborator

alexgg commented Nov 29, 2022

@balena-ci rebase

@ghost ghost force-pushed the mtoman/include-peak branch from debb904 to ec39a37 Compare November 29, 2022 13:52
@mtoman
Copy link
Contributor Author

mtoman commented Nov 29, 2022

@balena-ci rebase

@ghost ghost force-pushed the mtoman/include-peak branch from ec39a37 to e8be21d Compare November 29, 2022 17:03
@mtoman
Copy link
Contributor Author

mtoman commented Nov 29, 2022

Good question @jakogut - it is not included, I do not think we necessary need it but if we want to keep the two as feature-compatible as we can, it certainly would not hurt to include it. The sources are already in meta-balena. I'll open a separate PR in balena-intel.

@mtoman
Copy link
Contributor Author

mtoman commented Nov 30, 2022

@balena-ci rebase

@ghost ghost force-pushed the mtoman/include-peak branch from e8be21d to 04e67af Compare November 30, 2022 01:56
Copy link
Collaborator

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexgg alexgg merged commit 64b470f into master Nov 30, 2022
@alexgg alexgg deleted the mtoman/include-peak branch November 30, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants