Duplicate singleton instances after upgrading from 0.12.14 to 1.5.8

[uplink-t]

Node version: 18.14.2
Sails version (sails): 1.5.8
ORM hook version (sails-hook-orm): 4.0.2
Sockets hook version (sails-hook-sockets): 2.0.4
Organics hook version (sails-hook-organics): -
Grunt hook version (sails-hook-grunt): -
Uploads hook version (sails-hook-uploads): -
DB adapter & version (e.g. [email protected]): 3.0.1
Skipper adapter & version (e.g. [email protected]): -

---

We have several singletons that are written in TS (like most of the app). After the singleton instance is being created, initialization method need to be invoked, during witch singleton's private Map object is being populated from the DB. This step is being done in bootstrap.js (we tried it in app.js as well, on sails.lift).

The problem is that when starting Sails (using node app.js, or nodemon), it first instantiate the singletons (seems like it's being done by ts-node which compiles TS modules). However, when Sails lifts and reaches our code in bootstrap.js, it doesn't finds the already instantiated singleton object, and instead it creates a completely new singleton instance. At this step, the initialize method is being called and it is being initialized (populates the Map object) in bootstrap.js. But, when this singleton is being called from, lets say, one of the controllers, it calls the FIRST instance of the singleton, that has been created by ts-node, where Map object is not populated. In order to verify that, I added a private property to the singleton class that gets random numeric value on constructor run, and, indeed - there are 2 separate instances of the same singleton, and the first one, non-initialized one, is being called from the controller.

We also noticed that not only singletons are duplicated, and it affects on how our DB cache works.

Older 0.12.14 Sails version doesn't have this issue.

[sailsbot]

@tihrr Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.