Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounding page #168

Open
mkflow27 opened this issue Oct 17, 2024 · 0 comments
Open

Add rounding page #168

mkflow27 opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels
before release To review/tidy before release

Comments

@mkflow27
Copy link
Collaborator

Context:

The rounding parameter isn't very clear to me. I get the basic idea of always rounding in the Pool/Vault's favor, but without knowing when each function is called, it was confusing. I couldn't find anything in the docs about rounding - did I miss it somewhere?
Speaking of rounding: in both Stable and Weighted implementations and in the pending PR for Gyro 2 CLP, there's some logic for returning the computeInvariant rounded up and down. Is this always (or mostly) the case? It might be worth highlighting this pattern.

@mkflow27 mkflow27 self-assigned this Oct 17, 2024
@mkflow27 mkflow27 added the before release To review/tidy before release label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before release To review/tidy before release
Projects
None yet
Development

No branches or pull requests

1 participant