Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mv transfer function from VaultExtension to Vault #1079

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Mv transfer function from VaultExtension to Vault #1079

wants to merge 8 commits into from

Conversation

elshan-eth
Copy link
Contributor

@elshan-eth elshan-eth commented Oct 25, 2024 •
edited by EndymionJkb
Loading

Description

Move transfer function from VaultExtension to Vault for saving gas.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #531

joaobrunoah
joaobrunoah approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubeira jubeira mentioned this pull request Oct 28, 2024
Merged
12 tasks
jubeira
jubeira approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've hijacked the PR.
@EndymionJkb can you approve pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb left review comments

@joaobrunoah joaobrunoah joaobrunoah approved these changes

@jubeira jubeira jubeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch router: BPT transfers and approvals
4 participants
@elshan-eth @EndymionJkb @jubeira @joaobrunoah