Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer revert reason for 100% fees #1053

Open
EndymionJkb opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1054
Open

Clearer revert reason for 100% fees #1053

EndymionJkb opened this issue Oct 16, 2024 · 0 comments · May be fixed by #1054
Assignees
@EndymionJkb

Comments

@EndymionJkb
Copy link
Collaborator

Per auditor comment, the swapFeePercentage could be set to 100% for pools with dynamic fee hooks. In such a scenario, EXACT_OUT swaps will revert from ZeroDivision() as the complement() would be 0.
@EndymionJkb EndymionJkb self-assigned this Oct 16, 2024
@EndymionJkb EndymionJkb linked a pull request Oct 16, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EndymionJkb EndymionJkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Safer swap fee bounds balancer/balancer-v3-monorepo
1 participant
@EndymionJkb