Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review canDisableJoinExit #2089

Closed
EndymionJkb opened this issue Dec 1, 2022 · 0 comments · Fixed by #2100
Closed

Review canDisableJoinExit #2089

EndymionJkb opened this issue Dec 1, 2022 · 0 comments · Fixed by #2100
Assignees
@EndymionJkb

Comments

@EndymionJkb
Copy link
Collaborator

Minor point perhaps, since we aren't using our "native" managed pool controller, but I noticed the new canDisableJoinExit right in ManagedPoolRights. Given my understanding of the purpose of this change (safety during add/remove), should that be a separate right? It seems it should just be part of the changeTokens (add/remove) right, if it's required for the safety of that operation.

Otherwise you could have canChangeTokens true and canDisableJoinExit false, which would still prevent adding/removing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EndymionJkb EndymionJkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused controllers balancer/balancer-v2-monorepo
1 participant
@EndymionJkb