This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Add autorefresh to accounts #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional web3 instance that uses infura's mainnet websocket endpoint. On every new block we simply refresh the balance, transactions and unique tokens for a given account. Few things to note: - ACCOUNT_UPDATE_BALANCES_REQUEST wasn't being used so, removed it. - accountClearIntervals looks like it was replaced in favor of accountClearState, so removed that function as well. - web3 v1.0.0-beta34 that we're using has a bug connecting to any of the testnets on infura, downgrading to web3 v1.0.0-beta33 fixes the problem if we want to have a network specific subscription web3/web3.js#1559
|
Thanks @tluthra ! I'll take a deeper look at this next week! Just want to make sure we won't run into issues with our rate limits on various APIs - cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (check all)
CHANGELOG.mdto describe the included fixes and changes madeIssue number
#318
Changelog
Added refresh balances/transactions every new block
Details
Add an additional web3 instance that uses infura's mainnet websocket
endpoint. On every new block we simply refresh the balance,
transactions and unique tokens for a given account.
Few things to note:
accountClearState, so removed that function as well.
of the testnets on infura, downgrading to web3 v1.0.0-beta33 fixes
the problem if we want to have a network specific subscription
Invalid Websocket headers in 1.0.0-beta.34 web3/web3.js#1559