- SSHD-1173 Not fully using up a channel window may lead to hangs (see Channel windows below)
- SSHD-1293 ExplicitPortForwardingTracker does not unbind auto-allocated port
- SSHD-1294 Close MinaServiceFactory instances properly
- SSHD-1297 Avoid OutOfMemoryError when reading a public key from a corrupted Buffer
- New utility method
KeyUtils.loadPublicKey()
to read a public key file.
- Netty I/O back-end: respect configurations for
CoreModuleProperties.SOCKET_BACKLOG
andCoreModuleProperties.SOCKET_REUSEADDR
. - MINA I/O back-end: use
CoreModuleProperties.NIO2_READ_BUFFER_SIZE
for the initial read buffer size, if set. A newCoreModuleProperties.MIN_READ_BUFFER_SIZE
can be set to control the minimum read buffer size (64 bytes by default in Apache MINA).
Previous versions of Apache MINA sshd (from 2.6.0 to 2.9.1) did not always fully use up a channel window
and waited for a SSH_MSG_CHANNEL_WINDOW_ADJUST
message from the peer instead. It did so if the available
window size was smaller than the packet size of the channel, and also smaller than the amount of data still
to be written. There were settings to change this behavior and always fully use up a channel window: these
settings were
SftpModuleProperties.CHUNK_IF_WINDOW_LESS_THAN_PACKET
CoreModuleProperties.ASYNC_SERVER_STDOUT_CHUNK_BELOW_WINDOW_SIZE
CoreModuleProperties.ASYNC_SERVER_STDERR_CHUNK_BELOW_WINDOW_SIZE
By default, they were false
; if set to true
, the window would be used fully.
Not using up a channel window may lead to hangs with peers that send the SSH_MSG_CHANNEL_WINDOW_ADJUST
message
only when the window size is very low, or even zero. The SSH RFCs do not mandate any particular point at which
an implementation should adjust the window. OpenSSH and Apache MINA sshd itself do so when half of the window
is used up, but there are other implementations that do so only when the available window size becomes zero.
In this version, the above settings have been removed. Apache MINA sshd behaves always as if they were true
, i.e.,
if there is some window space and there is data to write, data will be written. See Apache MINA sshd issues
SSHD-1123 and SSHD-1173.