Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make parser support ES9 #58

Merged
merged 1 commit into from
Jun 5, 2019
Merged

fix: make parser support ES9 #58

merged 1 commit into from
Jun 5, 2019

Conversation

rndmerle
Copy link
Contributor

@rndmerle rndmerle commented Jun 1, 2019

When a Cypress test file contains function trailing-comma, such as:

fn(
  arg1,
  arg2,
)

The Falafel/Acorn parsing fails:

Unhandled rejection CypressError: cy.task('onlyTests') failed with the following error:> SyntaxError: Unexpected token (65:4)    at Parser.pp$4.raise (/Users/xxx/node_modules/falafel/node_modules/acorn/dist/acorn.js:2757:13)

Acorn needs to be configured with ES8 or ES9 support.

@bahmutov bahmutov merged commit 27f9b96 into bahmutov:master Jun 5, 2019
@bahmutov
Copy link
Owner

bahmutov commented Jun 5, 2019

Nice - thank you, I will even mark this as a feature

@bahmutov
Copy link
Owner

bahmutov commented Jun 5, 2019

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndmerle @bahmutov