Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compatible with Cypress v7 component testing #412

Merged
merged 12 commits into from
May 11, 2021
Merged

Conversation

LeJeanbono
Copy link
Collaborator

No description provided.

@LeJeanbono
Copy link
Collaborator Author

Fix #406

@cypress
Copy link

cypress bot commented Apr 25, 2021



Test summary

42 0 2 0


Run details

Project cypress-angular-unit-test
Status Passed
Commit cfb9263
Started May 11, 2021 9:21 PM
Ended May 11, 2021 9:23 PM
Duration 02:12 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@azaeng04
Copy link

@LeJeanbono not sure if you noticed, but the videos stop recording just when the test is about to start executing.

Copy link

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about grabbing the webpack configuration directly from the @angular-devkit/build-angular package?

@azaeng04
Copy link

@edbzn that would be really helpful. I have been trying to find where one can actually do that.

@lmiller1990
Copy link

Hi all - what do you think about moving the Cypress v7 Angular adapter into the main cypress repo inside of the npm directory (along side Vue and React)? It will become @cypress/angular on npm.

I can do this - development will still continue, just in the Cypress repo, and we will start to throw some more resources at it.

@lmiller1990
Copy link

I started migrating this to the main cypress monorepo. See here. I notice some tests are still failing - is this a known issue? Anything I can do to help out?

@azaeng04
Copy link

Amazing! @lmiller1990 Would be really great if more hands could jump on this so we can use it.

@LeJeanbono LeJeanbono merged commit 8b5e16c into master May 11, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sathish787
Copy link

Thank you all guys. Amazing Work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants