some changes in upsshipping v2.0

bagisto · Jan 5, 2024 · 0bf6e74 · 0bf6e74
1 parent e4b0c14
commit 0bf6e74
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/Carriers/Ups.php b/src/Carriers/Ups.php
@@ -13,7 +13,7 @@ class Ups extends AbstractShipping
      * Payment method code
      *
      * @var string
-    */
+     */
     protected $code  = 'ups';
 
     /**
@@ -37,9 +37,7 @@ public function calculate()
 
         $marketplaceShipping = session()->get('marketplace_shipping_rates');
 
-        if (isset($cartProducts) 
-            && $cartProducts == true) {
-
+        if (isset($cartProducts)) {
             foreach ($cartProducts as $key => $fedexServices) {
                 $rate = $totalShippingCost = 0;
                 $upsMethod = $methodCode = $key;

diff --git a/src/Helpers/ShippingMethodHelper.php b/src/Helpers/ShippingMethodHelper.php
@@ -61,6 +61,10 @@ public function getAllCartProducts($address)
      */
     protected function createSoapClient($address)
     {
+        if (! core()->getConfigData('sales.carriers.ups.ups_active')) {
+            return false;
+        }
+
         $cart = Cart::getCart();
 
         $defaultChannel = core()->getCurrentChannelCode();
@@ -71,11 +75,6 @@ protected function createSoapClient($address)
 
         $adminCompany = $adminData->hostname;
 
-        if (! core()->getConfigData('sales.carriers.ups.ups_active')) {
-
-            return false;
-        }
-
         $sellerAdminData = $this->upsRepository->getSellerAdminData($cart->items()->get(), 'ups_postcode');
 
         $sellerAdminServices = $allServices = [];
@@ -280,11 +279,11 @@ protected function getServiceName($serviceCode)
         ];
 
         foreach ($mapServices as $key => $service) {
-
             if ($key == $serviceCode) {
                 return $service;
             }
         }
+
         return $serviceCode;
     }
 
@@ -312,6 +311,7 @@ public function getWeight($weight)
         } else {
             $convertedWeight = $weight/0.45359237;
         }
+
         return $convertedWeight;
     }