Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add literal_pow overload #150

Closed
wants to merge 3 commits into from
Closed

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Dec 19, 2024

Mostly for performance:

f(x) = x^2

x = Particles()
xu = x*u"km"

@b f(x)  # goes from a few mus to hundreds of ns
@b f(xu)  # goes from a few ms (!) to hundreds of ns

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (6ca57ed) to head (37edce5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   90.28%   90.05%   -0.24%     
==========================================
  Files          20       20              
  Lines        1153     1156       +3     
==========================================
  Hits         1041     1041              
- Misses        112      115       +3     
Flag Coverage Δ
unittests 90.05% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen
Copy link
Owner

baggepinnen commented Dec 20, 2024

Thanks for the PR! I merged your commits with an additional test in #151

@aplavin aplavin deleted the patch-1 branch December 26, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants