Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-height problems with system-ui and ui-monospace #71

Open
badlydrawnrob opened this issue Jul 10, 2024 · 0 comments
Open

x-height problems with system-ui and ui-monospace #71

badlydrawnrob opened this issue Jul 10, 2024 · 0 comments
Labels
bug Something isn't working easy

Comments

@badlydrawnrob
Copy link
Owner

badlydrawnrob commented Jul 10, 2024

I'm removing this hack: use the same x-height for inline code and text.
I'm currently hacking the x-height by making inline <code> a little smaller.
system-ui and ui-monospace (on Mac) have a different x-height.
This makes inline code and code blocks feel massive!

The solution

  1. Use the exact same font-family in mono, making sure their x-heights are the same
  2. Use a variable font and change it's optical size
  3. Check two different font's x-height prior to using them. Make sure they match!

An example of the problem

Screenshot 2024-07-10 at 15 55 22

Image uses SF Pro and SF Mono on iOS and MacOs devices (at time of writing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy
Projects
None yet
Development

No branches or pull requests

1 participant