Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The v prefix is displayed on the release name if the release name shares the tag name #8598

Closed
PQCraft opened this issue Nov 7, 2022 · 7 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@PQCraft
Copy link

PQCraft commented Nov 7, 2022

Are you experiencing an issue with...

shields.io

🐞 Description

/github/v/release/PQCraft/CaveCube?display_name=release displays v0.4.5 while /github/v/release/PQCraft/PlatinumSrc?display_name=release displays Build 2022011900.
CaveCube's release name is the same as the tag name while PlatinumSrc adds "Build" before it.

🔗 Link to the badge

Correct:
Incorrect:

💡 Possible Solution

No response

@PQCraft PQCraft added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Nov 7, 2022
@chris48s
Copy link
Member

chris48s commented Nov 8, 2022

Formatting version numbers (or in this case, a release name which is a version number) with a leading v is a conscious decision. This is a discussion that has come up before and we've decided previously to keep this not user-configurable.

I think #6135 is probably the clearest articulation of it but there is some previous discussion in issues like #3200 and #1181

I'm going to close this as a duplicate. Cheers.

@chris48s chris48s closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2022
@PQCraft
Copy link
Author

PQCraft commented Nov 9, 2022

bruh 😐

@PQCraft
Copy link
Author

PQCraft commented Nov 9, 2022

That moment when your project is open source but doesn't like being open source

@calebcartwright
Copy link
Member

That moment when your project is open source but doesn't like being open source

It's unclear what outcome you were seeking with these comments, but this comes across as snarky and isn't particularly helpful. Projects that make their source code free and publicly available do not cede their ability to make decisions about the project, nor are they obliged to accept every request.

bruh neutral_face

For the benefit of other readers, this ☝️ from the prior comment is a dynamic badge constructed with the below badge url. Shields provides both general purpose/less opinionated badge builders in the form of our dynamic badges and endpoint badge, along with the more opinionated and consistent native badges.

The release badges for various platforms and services, including those mentioned in the OP are native badges, and thus have the message consistency applied. The dynamic badges are arbitrary, and do not.

https://img.shields.io/badge/dynamic/json?color=blue&label=Latest%20release&query=tag_name&url=https%3A%2F%2Fapi.github.com%2Frepos%2FPQCraft%2FCaveCube%2Freleases%2Flatest

@PQCraft
Copy link
Author

PQCraft commented Nov 10, 2022

t's unclear what outcome you were seeking with these comments, but this comes across as snarky and isn't particularly helpful. Projects that make their source code free and publicly available do not cede their ability to make decisions about the project, nor are they obliged to accept every request.

I was referring to the lack of customization options.

@PQCraft
Copy link
Author

PQCraft commented Nov 10, 2022

Like I can't even change the background color of the label text

@PQCraft
Copy link
Author

PQCraft commented Nov 10, 2022

It's very easy to add an option to remove the v prefix (add a formatVersion option or something) but no. Now I have to use the "inconsistent" endpoint badge that happens to be more consistent than the native badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

3 participants